Skip to content

Update for Dark Fog version#17

Open
starfi5h wants to merge 4 commits intomattsemar:masterfrom
starfi5h:0.10.x
Open

Update for Dark Fog version#17
starfi5h wants to merge 4 commits intomattsemar:masterfrom
starfi5h:0.10.x

Conversation

@starfi5h
Copy link
Copy Markdown
Contributor

@starfi5h starfi5h commented Dec 19, 2023 •
edited
Loading

In the new game version, Localization class is reworked so the string translate method has to change.
In this PR, the strings are stored in a static string pool Strings and reloaded after applying the options.
It no longer needs CommonAPI as a dependency and has built-in English and Chinese translation.

If the string.Translate() provides a translation to strings in the string pool, it will use the translation first.
In this way, you can add translations for other languages by other translation plugins.

Fix #16, #14

@shaskola
Copy link
Copy Markdown

shaskola commented Dec 19, 2023

You are a GOD!
Thanks Starfi5sh whoever you are <3

I would recommend you take this git and duplicate it in the modstore for everyone, if Semar is never taking this again, it would be greatly beneficial for everyone in the community to have a new mod they can use. Regardless of that, I am grateful for this contribution

@ChinaShopBully
Copy link
Copy Markdown

ChinaShopBully commented Dec 20, 2023 •
edited
Loading

I agree completely with Shaskola! Taking over abandoned mods is a great tradition! Remember Bottleneck was itself the answer to BetterStats being abandoned!

And starfi5h is indeed the master! I use 11 of his mods!

@mxujm1
Copy link
Copy Markdown

mxujm1 commented Dec 22, 2023

thk

@shenjackyuanjie
Copy link
Copy Markdown

shenjackyuanjie commented Dec 27, 2023

@starfi5h 目前还是会有一些似乎不会影响使用的 warning

[Warning:  HarmonyX] AccessTools.GetTypesFromAssembly: assembly Bottleneck, Version=1.0.16.0, Culture=neutral, PublicKeyToken=null => System.Reflection.ReflectionTypeLoadException: Exception of type 'System.Reflection.ReflectionTypeLoadException' was thrown.
  at (wrapper managed-to-native) System.Reflection.Assembly.GetTypes(System.Reflection.Assembly,bool)
  at System.Reflection.Assembly.GetTypes () [0x00000] in <2fa7a6a452ca43df998f07fd1486c0df>:IL_0000
  at HarmonyLib.AccessTools.GetTypesFromAssembly (System.Reflection.Assembly assembly) [0x0000d] in <474744d65d8e460fa08cd5fd82b5d65f>:IL_000D
[Message:   BepInEx] Chainloader startup complete
[Warning: Unity Log] [Locale] 160 个词条未找到翻译文本
[Info   :SF_ChinesePatch] Add 61 strings to ZHCN
Setting breakpad minidump AppID = 1366540
SteamInternal_SetMinidumpSteamID:  Caching Steam ID:  76561198973642870 [API loaded no]
[Info   : Unity Log] MoreStatInfo Start
[Info   :DSP Mod Save] DSP Mod Save is initialized!
[Info   :More Graphics Options] Mod Installing.
[Info   : Unity Log] 快捷键已启用
[Warning:  HarmonyX] AccessTools.GetTypesFromAssembly: assembly Bottleneck, Version=1.0.16.0, Culture=neutral, PublicKeyToken=null => System.Reflection.ReflectionTypeLoadException: Exception of type 'System.Reflection.ReflectionTypeLoadException' was thrown.
  at (wrapper managed-to-native) System.Reflection.Assembly.GetTypes(System.Reflection.Assembly,bool)
  at System.Reflection.Assembly.GetTypes () [0x00000] in <2fa7a6a452ca43df998f07fd1486c0df>:IL_0000
  at HarmonyLib.AccessTools.GetTypesFromAssembly (System.Reflection.Assembly assembly) [0x0000d] in <474744d65d8e460fa08cd5fd82b5d65f>:IL_000D
[Error  : Unity Log] Can't remove RectTransform because Image (Script) depends on it

@RedRun51
Copy link
Copy Markdown

RedRun51 commented Jan 1, 2024

@starfi5h Could you perhaps take another look at this mod, it doesn't work anymore since the last update a few days ago. Thanks!

@starfi5h
Copy link
Copy Markdown
Contributor Author

starfi5h commented Jan 2, 2024

@RedRun51 The update in 0.10.28.21150 renames some of the functions.
The fixed version 1.0.17 is updated on Thunderstore:
https://dsp.thunderstore.io/package/starfi5h/Bottleneck/

@starfi5h starfi5h closed this Feb 18, 2024
@starfi5h starfi5h deleted the 0.10.x branch February 18, 2024 21:38
@starfi5h starfi5h restored the 0.10.x branch February 18, 2024 21:40
@starfi5h starfi5h reopened this Feb 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Error with the new Dark Fog version

6 participants

@starfi5h @shaskola @ChinaShopBully @mxujm1 @shenjackyuanjie @RedRun51